-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump sigstore-conformance to v0.0.14 release #3965
Conversation
Signed-off-by: Bob Callaway <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3965 +/- ##
==========================================
- Coverage 40.10% 36.46% -3.65%
==========================================
Files 155 209 +54
Lines 10044 13312 +3268
==========================================
+ Hits 4028 4854 +826
- Misses 5530 7839 +2309
- Partials 486 619 +133 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little -1 on this, as a change in conformance testing can cause builds to start failing (so we'd need to fix it right away or override branch protection). Dependabot PRs should already take care of the version bumps, and we can see the test failures before they land in main. Of course, releases only happen so often so it's nice to know about failures early...
Alternatively, we can have two conformance workflows, one with the latest pinned release and the second running against main, and only use branch protection on the pinned one so that branch protection is stable. What do you think of that?
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
aside: dependabot wasn't working here, because this was back pinned to v0.0.11 which was released in March... |
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
i'll downscope this change to just get to the latest release. I still vote +1 on this because if we have a valid conformance test that isn't passing on a client, then the client should be updated ASAP in my opinion (and block other changes/releases). |
Signed-off-by: Bob Callaway <[email protected]>
This updates to the latest release of sigstore-conformance